Small project cleanup#935
Conversation
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors downloader.rb to extract content length retrieval into a dedicated method and modifies project.rb by removing a platform existence check and reformatting workspace path construction. Review feedback indicates that the new error message in the downloader is less informative because it omits the HTTP status code, and that removing the platform check in project.rb will result in generic NoMethodError exceptions rather than clear, actionable error messages.
There was a problem hiding this comment.
Pull request overview
This PR performs small cleanup/refactors in the project initialization and download helper logic.
Changes:
- Removes a platform-not-found guard from
Project#images_names_query_output. - Refactors
Downloader#downloadto delegate HEAD/content-length lookup to a helper method. - Minor formatting cleanup for workspace path construction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/project.rb | Removes a nil-guard in the query output path and reformats File.join arguments for workspace creation. |
| lib/auxiliary/downloader.rb | Extracts HEAD/content-length logic into load_total_size and updates the associated error handling/message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.