Skip to content

Define several new platforms#939

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:host-platforms
Apr 30, 2026
Merged

Define several new platforms#939
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:host-platforms

Conversation

@kostyanf14
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Copilot AI review requested due to automatic review settings April 30, 2026 07:55
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds four new JSON configuration files defining platform settings for Windows 2019 and 2022 host environments, including both standard and GUI variants, for the hcktest engine. I have no feedback to provide.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new HLK/AutoHCK platform definitions to support running Windows Server 2019/2022 client VMs with cpu: host, including GUI variants, within the existing hcktest platform catalog.

Changes:

  • Add Win2019x64_host and Win2019x64_host_gui platform JSONs.
  • Add Win2022x64_host and Win2022x64_host_gui platform JSONs.
  • Configure each new platform with two clients (CL1/CL2) using existing HLK images and WinRM addresses.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
lib/engines/hcktest/platforms/Win2022x64_host.json New Win2022 host-CPU platform definition (Core).
lib/engines/hcktest/platforms/Win2022x64_host_gui.json New Win2022 host-CPU platform definition (GUI).
lib/engines/hcktest/platforms/Win2019x64_host.json New Win2019 host-CPU platform definition (Core).
lib/engines/hcktest/platforms/Win2019x64_host_gui.json New Win2019 host-CPU platform definition (GUI).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/engines/hcktest/platforms/Win2019x64_host_gui.json
Comment thread lib/engines/hcktest/platforms/Win2022x64_host.json
Comment thread lib/engines/hcktest/platforms/Win2022x64_host_gui.json
Comment thread lib/engines/hcktest/platforms/Win2019x64_host.json
Comment thread lib/engines/hcktest/platforms/Win2019x64_host_gui.json
Comment thread lib/engines/hcktest/platforms/Win2022x64_host_gui.json
Comment thread lib/engines/hcktest/platforms/Win2019x64_host.json
@kostyanf14 kostyanf14 merged commit cb12c9e into HCK-CI:master Apr 30, 2026
13 checks passed
@kostyanf14 kostyanf14 deleted the host-platforms branch April 30, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants