VIRTWINKVM-2164: Fix Flush Test parameters for HLK1607#945
Conversation
HLK1607 expects SNMP_IP_ADDRESS and SNMP_PORT, while newer kits use IP and Outlet. Split the test in hcktest.json into two kit entries. Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
|
Resolve: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the test configuration for the 'Flush Test' by introducing kit-specific parameters, specifically adding SNMP settings for HLK1607 and restricting standard IP parameters to a defined list of newer HLK versions. Feedback indicates that the explicit list of kits is brittle and likely incomplete, which could lead to regressions for omitted versions; a more robust approach using default settings or exclusion logic was suggested.
| "kits": ["HLK1809", "HLK1809server", "HLK2004", "HLK20H2", "HLK2022", "HLK2025", "HLK2025_next", | ||
| "HLK11_22H2", "HLK11_23H2", "HLK11_24H2", "HLK11_25H2", "HLK11_next"], |
There was a problem hiding this comment.
The explicit list of kits for the "Flush Test" parameters is brittle and likely incomplete. It excludes several valid HLK versions (e.g., 1703, 1709, 1803, 1903) and will require manual updates for every future HLK release. Since the original configuration applied to all kits (by having no kits restriction), this change introduces a regression for any kit not explicitly listed here.
If the newer kits can safely ignore the HLK1607-specific parameters, a more robust approach would be to keep the standard parameters in a block with an empty kits array (acting as a default) and provide the HLK1607 overrides in a separate block. If the parameters must be mutually exclusive, consider updating the engine to support a "default" or "exclude" mechanism to avoid maintaining exhaustive lists of all other versions.
There was a problem hiding this comment.
good idea, but no "exclude" mechanism for now
| "kits": ["HLK1809", "HLK1809server", "HLK2004", "HLK20H2", "HLK2022", "HLK2025", "HLK2025_next", | ||
| "HLK11_22H2", "HLK11_23H2", "HLK11_24H2", "HLK11_25H2", "HLK11_next"], |
There was a problem hiding this comment.
Looks like we need a new option for this, but looks good for now
2 participants
HLK1607 expects SNMP_IP_ADDRESS and SNMP_PORT, while newer kits use IP and Outlet. Split the test in hcktest.json into two kit entries.