Add whiteboard#971
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “whiteboard” field that can be provided via CLI and propagated through the run (logged at startup) and into generated artifacts (HTML results report, YAML report data, and JUnit properties).
Changes:
- Adds
--whiteboard <text>to common CLI options and stores it onProject. - Includes
whiteboardinresults.html/results.yamlreport data and JUnit<properties>. - Logs the whiteboard value at project initialization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/templates/report.html.erb | Displays the whiteboard value in the HTML results report. |
| lib/result_report.rb | Adds whiteboard to the report data hash used for HTML/YAML generation. |
| lib/project.rb | Stores and logs the whiteboard value on the Project. |
| lib/junit.rb | Adds whiteboard to the JUnit properties map. |
| lib/cli.rb | Introduces the --whiteboard CLI flag on common options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request introduces a 'whiteboard' feature, allowing users to include custom text in logs, JUnit properties, and HTML reports via a new --whiteboard CLI option. The feedback highlights the need for conditional rendering of the whiteboard section in the HTML report to avoid empty alert boxes and recommends HTML escaping the output to prevent potential XSS vulnerabilities.
YanVugenfirer
left a comment
There was a problem hiding this comment.
Escaping HTML might be a good idea, otherwise looks good
668d30b to
5d345df
Compare
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
No description provided.