Skip to content

Add whiteboard#971

Merged
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:whiteboard
May 26, 2026
Merged

Add whiteboard#971
kostyanf14 merged 1 commit into
HCK-CI:masterfrom
kostyanf14:whiteboard

Conversation

@kostyanf14
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 20, 2026 16:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “whiteboard” field that can be provided via CLI and propagated through the run (logged at startup) and into generated artifacts (HTML results report, YAML report data, and JUnit properties).

Changes:

  • Adds --whiteboard <text> to common CLI options and stores it on Project.
  • Includes whiteboard in results.html/results.yaml report data and JUnit <properties>.
  • Logs the whiteboard value at project initialization.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/templates/report.html.erb Displays the whiteboard value in the HTML results report.
lib/result_report.rb Adds whiteboard to the report data hash used for HTML/YAML generation.
lib/project.rb Stores and logs the whiteboard value on the Project.
lib/junit.rb Adds whiteboard to the JUnit properties map.
lib/cli.rb Introduces the --whiteboard CLI flag on common options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/templates/report.html.erb Outdated
Comment thread lib/templates/report.html.erb
Comment thread lib/project.rb Outdated
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'whiteboard' feature, allowing users to include custom text in logs, JUnit properties, and HTML reports via a new --whiteboard CLI option. The feedback highlights the need for conditional rendering of the whiteboard section in the HTML report to avoid empty alert boxes and recommends HTML escaping the output to prevent potential XSS vulnerabilities.

Comment thread lib/templates/report.html.erb
Copy link
Copy Markdown
Contributor

@YanVugenfirer YanVugenfirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaping HTML might be a good idea, otherwise looks good

Comment thread lib/templates/report.html.erb Outdated
Comment thread lib/templates/report.html.erb
@kostyanf14 kostyanf14 force-pushed the whiteboard branch 2 times, most recently from 668d30b to 5d345df Compare May 25, 2026 11:48
@kostyanf14 kostyanf14 requested a review from YanVugenfirer May 25, 2026 11:48
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
@kostyanf14 kostyanf14 merged commit c0b98d2 into HCK-CI:master May 26, 2026
9 checks passed
@kostyanf14 kostyanf14 deleted the whiteboard branch May 26, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants