Conversation
Bump minor due to API changes and backward compatibility breaks. Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's version number to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 0.6.4 to 0.7.0 across lib/version.rb and tools/toolsHCK.ps1. A review comment highlighted that the version number is currently hardcoded in multiple locations, which could lead to inconsistencies. It was suggested to centralize the version definition into a single source of truth to improve maintainability.
|
|
||
| ## | ||
| $Version = "0.6.4" | ||
| $Version = "0.7.0" |
There was a problem hiding this comment.
The version number is hardcoded here and also in lib/version.rb. This duplication can lead to inconsistencies when updating the version. To improve maintainability, consider defining the version in a single place, for example, in a VERSION file at the root of the repository.
Both the Ruby code and this PowerShell script could then read the version from this file.
For example, you could have a VERSION file with just:
0.7.0
In lib/version.rb:
# frozen_string_literal: true
# rtoolsHCK version extend to class
class RToolsHCK
# Current rtoolsHCK version
VERSION = File.read(File.expand_path('../VERSION', __dir__)).strip
endIn tools/toolsHCK.ps1:
$Version = Get-Content -Path (Join-Path $PSScriptRoot '..\VERSION') -RawThis would ensure there is a single source of truth for the version number.
There was a problem hiding this comment.
Pull request overview
Updates rtoolsHCK’s reported version to 0.7.0 to reflect the stated minor bump for API changes/backward-incompatible behavior.
Changes:
- Bump PowerShell tool wrapper version string to
0.7.0. - Bump Ruby gem/library version constant to
0.7.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/toolsHCK.ps1 | Updates $Version used by the PowerShell wrapper to 0.7.0. |
| lib/version.rb | Updates RToolsHCK::VERSION to 0.7.0 (propagates to gemspec via RToolsHCK::VERSION). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bump minor due to API changes and backward compatibility breaks.