build: avoid using a fixed version in HDF5_Examples.cmake.in#6328
Merged
build: avoid using a fixed version in HDF5_Examples.cmake.in#6328
Conversation
hyoklee
requested review from
bmribler,
brtnfld,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
brtnfld
reviewed
Mar 30, 2026
| @@ -83,7 +83,7 @@ set(ADD_BUILD_OPTIONS "${ADD_BUILD_OPTIONS} -DSITE:STRING=${CTEST_SITE} -DBUILDN | |||
|
|
|||
| #TAR_SOURCE - name of tarfile | |||
Collaborator
There was a problem hiding this comment.
The commented block has two problems:
- Stale hard-coded version (2.0.1)
- The if(NOT DEFINED TAR_SOURCE) guard is meaningless — TAR_SOURCE is never defined or used anywhere in the codebase. The guard and the variable being set (CTEST_USE_TAR_SOURCE) are different names. The guard would always evaluate true and add nothing.
Correct fix
Drop the bogus guard entirely and match the pattern used in HDF5config.cmake:
#TAR_SOURCE - name of tarfile
#set(CTEST_USE_TAR_SOURCE "HDF5Examples-@HDF5_PACKAGE_VERSION@-Source")
This is simpler, consistent with the rest of the codebase, and still conveys what the user needs to do (uncomment and set the variable).
lrknox
previously approved these changes
Mar 30, 2026
glennsong09
previously approved these changes
Mar 31, 2026
lrknox
approved these changes
Mar 31, 2026
brtnfld
approved these changes
Mar 31, 2026
github-project-automation
bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6260