Article Updates#40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
On_Start
On_Start now runs at the end of the BattleObjectModuleAccessor::start function instead of specifically while starting LuaModule. This allows WorkModule to be started, letting you set flags, ints, and floats in an on_start.
Update Weapon Count
Allows you to update how many of a specific article the fighter is allowed to have.
Weapon Cloning Bugfix
Currently, the way that weapon cloning works is such:
original article namewould be passed into a StaticArrayAccessor, which then spits out an article index.However, this doesn't account for articles with the same name, such as Mario and Luigi's Fireball. If you tried cloning Luigi's Fireball, for example, the game would assign the new article Mario's fireball weapon ID, which would cause the game to crash.
Weapon cloning will now work by directly passing in the article's ID: