Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jul 8, 2021

This PR is a two stage PR, setup the hooks and then run them.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #444 (8e1de84) into master (3800cc2) will increase coverage by 0.02%.
The diff coverage is 96.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   93.84%   93.86%   +0.02%     
==========================================
  Files          44       44              
  Lines        2761     2754       -7     
  Branches      391      391              
==========================================
- Hits         2591     2585       -6     
  Misses        129      129              
+ Partials       41       40       -1     
Flag Coverage Δ
python-3.6 93.26% <94.51%> (-0.02%) ⬇️
python-3.9 93.38% <94.77%> (+0.01%) ⬆️
python-pypy-3.7 93.40% <95.56%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/decisionengine/framework/logicengine/Rule.py 100.00% <ø> (ø)
src/decisionengine/framework/util/subclasses.py 100.00% <ø> (ø)
...rc/decisionengine/framework/modules/SourceProxy.py 65.71% <68.75%> (ø)
.../decisionengine/framework/engine/DecisionEngine.py 90.19% <91.93%> (ø)
...gine/framework/dataspace/datasources/postgresql.py 82.44% <92.72%> (ø)
src/decisionengine/framework/engine/de_client.py 94.78% <96.66%> (ø)
src/decisionengine/framework/about.py 100.00% <100.00%> (ø)
...ionengine/framework/config/ChannelConfigHandler.py 95.94% <100.00%> (ø)
src/decisionengine/framework/config/ValidConfig.py 95.34% <100.00%> (ø)
src/decisionengine/framework/config/policies.py 100.00% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3800cc2...8e1de84. Read the comment docs.

@jcpunk jcpunk mentioned this pull request Aug 5, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Aug 5, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Aug 23, 2021
@jcpunk jcpunk changed the title Setup isort and pyupgrade Setup black, isort, and pyupgrade Aug 25, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Sep 8, 2021
@jcpunk jcpunk marked this pull request as ready for review September 16, 2021 18:37
knoepfel
knoepfel previously approved these changes Sep 17, 2021
Copy link
Contributor

@knoepfel knoepfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pat, thanks so much for spear-heading this.

@jcpunk
Copy link
Contributor Author

jcpunk commented Sep 17, 2021

As a reminder, you'll want to setup pre-commit on your dev box once this gets merged to take full advantage :
For more information see

@jcpunk
Copy link
Contributor Author

jcpunk commented Sep 17, 2021

I just added a few manual corrections to things that probably don't matter and wont bug anyone but me (mostly consistent use of @pytest.fixture() vs @pytest.fixture)

@jcpunk jcpunk requested a review from knoepfel September 17, 2021 17:17
@mambelli mambelli merged commit a6a81ce into HEPCloud:master Sep 17, 2021
@jcpunk jcpunk deleted the isort-pyupgrade branch September 17, 2021 19:18
shreyb added a commit to shreyb/decisionengine that referenced this pull request Sep 23, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Oct 6, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Oct 13, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Oct 15, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Oct 22, 2021
shreyb added a commit to shreyb/decisionengine that referenced this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants