Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Oct 5, 2021

The DE server should never be run as root. There are a ton of good reasons to forbid this.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #534 (0665ce9) into master (c4fc599) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   83.54%   83.70%   +0.16%     
==========================================
  Files          47       47              
  Lines        3081     3081              
  Branches      430      430              
==========================================
+ Hits         2574     2579       +5     
+ Misses        467      465       -2     
+ Partials       40       37       -3     
Flag Coverage Δ
python-3.6 83.00% <ø> (ø)
python-3.9 83.17% <ø> (ø)
python-pypy-3.7 83.30% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 90.73% <ø> (+0.51%) ⬆️
...ecisionengine/framework/taskmanager/TaskManager.py 96.48% <0.00%> (-0.02%) ⬇️
src/decisionengine/framework/dataspace/maintain.py 99.04% <0.00%> (+0.95%) ⬆️
src/decisionengine/framework/engine/Workers.py 90.27% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fc599...0665ce9. Read the comment docs.

@mambelli mambelli merged commit 1e78a88 into HEPCloud:master Oct 6, 2021
@jcpunk jcpunk deleted the no-root branch October 6, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants