Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Oct 12, 2021

Turns out my test EL7 box had a newer golang in /usr/local/bin/ from when I was hacking on jsonnet for packaging purposes.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #543 (cda5511) into master (e95071f) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   83.83%   83.99%   +0.16%     
==========================================
  Files          48       48              
  Lines        3099     3099              
  Branches      483      483              
==========================================
+ Hits         2598     2603       +5     
+ Misses        463      461       -2     
+ Partials       38       35       -3     
Flag Coverage Δ
python-3.10 83.44% <ø> (ø)
python-3.6 83.29% <ø> (+0.12%) ⬆️
python-pypy-3.7 83.55% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 90.48% <0.00%> (+0.48%) ⬆️
src/decisionengine/framework/dataspace/maintain.py 100.00% <0.00%> (+0.95%) ⬆️
src/decisionengine/framework/engine/Workers.py 90.27% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95071f...cda5511. Read the comment docs.

Copy link
Contributor

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just to make sure - commenting this out will exclude any jsonnet checks by go-jsonnet (which you were originally trying to add?)

@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 13, 2021

Yep, I was hopeful to get the autoformatting all in place but alas....

@mambelli mambelli merged commit 30951a5 into HEPCloud:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants