Skip to content

Conversation

@knoepfel
Copy link
Contributor

This PR refactors some of the task-manager code to make it more conducive for Kombu's producer/consumer pattern. It also removes some code that we will likely not be using.

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2021

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-29 17:04:34 UTC

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #549 (8abdbad) into master (1cbc733) will increase coverage by 10.85%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #549       +/-   ##
===========================================
+ Coverage   84.19%   95.04%   +10.85%     
===========================================
  Files          48       45        -3     
  Lines        3093     2743      -350     
  Branches      481      437       -44     
===========================================
+ Hits         2604     2607        +3     
+ Misses        454      103      -351     
+ Partials       35       33        -2     
Flag Coverage Δ
python-3.10 94.93% <95.65%> (+10.83%) ⬆️
python-3.6 94.65% <95.65%> (+10.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ecisionengine/framework/taskmanager/TaskManager.py 96.51% <95.38%> (+0.02%) ⬆️
.../decisionengine/framework/engine/DecisionEngine.py 89.26% <100.00%> (ø)
...isionengine/framework/managers/ComponentManager.py 92.68% <100.00%> (ø)
...cisionengine/framework/taskmanager/module_graph.py 100.00% <100.00%> (ø)
src/decisionengine/framework/dataspace/maintain.py 100.00% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbc733...8abdbad. Read the comment docs.

@mambelli mambelli merged commit 4f920dc into HEPCloud:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants