-
Notifications
You must be signed in to change notification settings - Fork 28
Use kombu to communicate data from sources to cycles #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc4d234 to
e852a8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 95.38% 95.39% +0.01%
==========================================
Files 45 45
Lines 2688 2716 +28
Branches 445 442 -3
==========================================
+ Hits 2564 2591 +27
- Misses 90 91 +1
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b6d7255 to
9a648ba
Compare
|
@jcpunk, I believe I've addressed your comments. Let me know if further adjustments are required. |
jcpunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me :)
This PR uses kombu to communicate data products from sources to cycles. There are no user-facing breaking changes. By default, all communication happens in memory. A different communication backend can be enabled by specifying the
broker_urlparameter as part of the global configuration (e.g.):{ broker_url: "redis://localhost:6379/0" }