Skip to content

Conversation

@knoepfel
Copy link
Contributor

@knoepfel knoepfel commented Nov 9, 2021

This PR uses kombu to communicate data products from sources to cycles. There are no user-facing breaking changes. By default, all communication happens in memory. A different communication backend can be enabled by specifying the broker_url parameter as part of the global configuration (e.g.):

{
  broker_url: "redis://localhost:6379/0"
}

@pep8speaks
Copy link

pep8speaks commented Nov 9, 2021

Hello @knoepfel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-15 15:20:57 UTC

@knoepfel knoepfel marked this pull request as draft November 9, 2021 22:40
@knoepfel knoepfel force-pushed the kombu branch 6 times, most recently from bc4d234 to e852a8e Compare November 10, 2021 17:28
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #556 (ee4a423) into master (82faa27) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   95.38%   95.39%   +0.01%     
==========================================
  Files          45       45              
  Lines        2688     2716      +28     
  Branches      445      442       -3     
==========================================
+ Hits         2564     2591      +27     
- Misses         90       91       +1     
  Partials       34       34              
Flag Coverage Δ
python-3.10 95.25% <100.00%> (-0.03%) ⬇️
python-3.6 95.07% <98.98%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ecisionengine/framework/taskmanager/TaskManager.py 98.37% <100.00%> (+1.59%) ⬆️
...rc/decisionengine/framework/modules/SourceProxy.py 78.26% <0.00%> (-8.70%) ⬇️
src/decisionengine/framework/dataspace/maintain.py 100.00% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82faa27...ee4a423. Read the comment docs.

@knoepfel knoepfel force-pushed the kombu branch 2 times, most recently from b6d7255 to 9a648ba Compare November 10, 2021 19:17
@knoepfel knoepfel changed the title First implementation using Kombu/redis to communicate data Use kombu to communicate data from sources to cycles Nov 10, 2021
@knoepfel knoepfel marked this pull request as ready for review November 10, 2021 19:19
@knoepfel
Copy link
Contributor Author

@jcpunk, I believe I've addressed your comments. Let me know if further adjustments are required.

Copy link
Contributor

@jcpunk jcpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me :)

@mambelli mambelli merged commit c939a6e into HEPCloud:master Nov 16, 2021
@knoepfel knoepfel deleted the kombu branch November 16, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants