Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Nov 17, 2021

This should help us get kombu running as a multi process tool in the CI tests.

@vitodb if this looks right we'll need to rebuild the containers on docker hub and Jenkins.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #565 (97b334d) into master (9cbffe9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   95.42%   95.39%   -0.03%     
==========================================
  Files          45       45              
  Lines        2688     2716      +28     
  Branches      445      442       -3     
==========================================
+ Hits         2565     2591      +26     
- Misses         90       91       +1     
- Partials       33       34       +1     
Flag Coverage Δ
python-3.10 95.25% <ø> (-0.03%) ⬇️
python-3.6 95.04% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/decisionengine/framework/modules/SourceProxy.py 78.26% <0.00%> (-8.70%) ⬇️
...ecisionengine/framework/taskmanager/TaskManager.py 98.37% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbffe9...97b334d. Read the comment docs.

@vitodb vitodb self-requested a review November 17, 2021 21:28
Copy link
Contributor

@vitodb vitodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I'll rebuild the Docker container as soon as this PR is merged.

@mambelli mambelli merged commit 24ba527 into HEPCloud:master Nov 18, 2021
@jcpunk jcpunk deleted the docker-redis-tests branch November 18, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants