Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jan 13, 2022

Some unit tests in #568 are erroring out during startup. This should help get more logging in place so we can get a better picture why.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #598 (e23c14e) into master (dbd49a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e23c14e differs from pull request most recent head a576a07. Consider uploading reports for the commit a576a07 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +0.01%     
==========================================
  Files          46       46              
  Lines        2749     2759      +10     
  Branches      439      439              
==========================================
+ Hits         2638     2648      +10     
  Misses         77       77              
  Partials       34       34              
Flag Coverage Δ
python-3.10 95.86% <100.00%> (+0.01%) ⬆️
python-3.6 95.66% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 90.02% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd49a6...a576a07. Read the comment docs.

goodenou
goodenou previously approved these changes Jan 13, 2022
Copy link
Contributor

@goodenou goodenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me Pat.

@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 13, 2022

Thanks Lisa! I thought up a few more places we might be getting stuck and updated the PR.

Co-authored-by: Kyle Knoepfel <knoepfel@fnal.gov>
@mambelli mambelli merged commit afcc7cf into HEPCloud:master Jan 18, 2022
@jcpunk jcpunk deleted the morestartuplogs branch January 18, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants