Skip to content

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Feb 2, 2022

As I look at ways of testing cherrypy, having these decoupled from the test files may prove valuable.

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2022

Hello @jcpunk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-02 19:46:40 UTC

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #603 (ff698ec) into master (6117cc9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   96.04%   96.05%           
=======================================
  Files          47       47           
  Lines        2835     2840    +5     
  Branches      449      450    +1     
=======================================
+ Hits         2723     2728    +5     
  Misses         83       83           
  Partials       29       29           
Flag Coverage Δ
python-3.10 95.77% <ø> (+<0.01%) ⬆️
python-3.6 95.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../decisionengine/framework/engine/DecisionEngine.py 88.01% <0.00%> (+0.04%) ⬆️
src/decisionengine/framework/engine/de_client.py 96.69% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6117cc9...ff698ec. Read the comment docs.

@jcpunk jcpunk requested a review from shreyb February 2, 2022 19:57
@mambelli mambelli merged commit e60efe7 into HEPCloud:master Feb 3, 2022
@jcpunk jcpunk deleted the metrics-fixtures branch February 3, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants