Skip to content

Logger tests are a bit unstable at high parallelization.#619

Merged
mambelli merged 1 commit intoHEPCloud:masterfrom
jcpunk:testing-parallel
Feb 14, 2022
Merged

Logger tests are a bit unstable at high parallelization.#619
mambelli merged 1 commit intoHEPCloud:masterfrom
jcpunk:testing-parallel

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Feb 10, 2022

This should help avoid races between them

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #619 (655f2ba) into master (de7829a) will increase coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 655f2ba differs from pull request most recent head 9df6973. Consider uploading reports for the commit 9df6973 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   96.52%   96.55%   +0.03%     
==========================================
  Files          47       47              
  Lines        2847     2847              
  Branches      451      451              
==========================================
+ Hits         2748     2749       +1     
+ Misses         69       67       -2     
- Partials       30       31       +1     
Flag Coverage Δ
python-3.10 96.31% <50.00%> (+0.10%) ⬆️
python-3.6 95.94% <50.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/decisionengine/framework/modules/de_logger.py 89.36% <50.00%> (-2.13%) ⬇️
src/decisionengine/framework/dataspace/maintain.py 99.04% <0.00%> (-0.96%) ⬇️
.../decisionengine/framework/engine/DecisionEngine.py 90.85% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7829a...9df6973. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Feb 10, 2022

Hello @jcpunk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-10 20:19:52 UTC

This should help avoid races between them
@jcpunk
Copy link
Contributor Author

jcpunk commented Feb 10, 2022

@knoepfel I have no idea why these tests pass on my local instance and fail up here... any pointers would be handy.

@knoepfel
Copy link
Contributor

@jcpunk, for kicks, can you run this test using only 1 pytest-xdist worker?

@mambelli mambelli merged commit 7547720 into HEPCloud:master Feb 14, 2022
@jcpunk
Copy link
Contributor Author

jcpunk commented Feb 14, 2022

with one worker it runs, but it was passing locally with multiple workers

@jcpunk jcpunk deleted the testing-parallel branch February 15, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants