Skip to content

Create a neat CLI with the help of boost::program_options#9

Merged
ArturAkh merged 9 commits intotest/sgbatchfrom
test/sgbatch-cli
Jan 17, 2022
Merged

Create a neat CLI with the help of boost::program_options#9
ArturAkh merged 9 commits intotest/sgbatchfrom
test/sgbatch-cli

Conversation

@HerrHorizontal
Copy link
Collaborator

This replaces the outdated draft for an CLI with the help of the functionalities provided by Boost.Program_options.

@HerrHorizontal HerrHorizontal added the enhancement New feature or request label Jan 14, 2022
@HerrHorizontal HerrHorizontal self-assigned this Jan 14, 2022
@HerrHorizontal HerrHorizontal linked an issue Jan 14, 2022 that may be closed by this pull request
Copy link
Collaborator

@ArturAkh ArturAkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerrHorizontal thanks for this CLI, looks good!

Maybe we can also think of outsourcing that to a separate header to avoid too large merge-conflicts.

On the other hand, there is a good overview over the changes made, so I think we can merge the pull request now and see what happens if merging into wrench 2.0 branch.

@ArturAkh ArturAkh merged commit 20c6ca5 into test/sgbatch Jan 17, 2022
@HerrHorizontal
Copy link
Collaborator Author

@HerrHorizontal thanks for this CLI, looks good!

Maybe we can also think of outsourcing that to a separate header to avoid too large merge-conflicts.

On the other hand, there is a good overview over the changes made, so I think we can merge the pull request now and see what happens if merging into wrench 2.0 branch.

I think the old hacky-wrench simulator is finalized with this PR. So there is no need for substancial changes. For Wrench2.0 I plan to cherry-pick the merge commit.

@HerrHorizontal HerrHorizontal deleted the test/sgbatch-cli branch January 17, 2022 10:37
@HerrHorizontal
Copy link
Collaborator Author

This closes #5

@HerrHorizontal HerrHorizontal mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actual CLI needed

3 participants