Remove pin on Pylint to support Python 3.11#260
Merged
Conversation
GraemeWatt
force-pushed
the
upgrade-pylint
branch
from
10d5cd4 to
fdb6b5e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 87.99% 89.75% +1.75%
==========================================
Files 5 5
Lines 1083 1083
Branches 231 241 +10
==========================================
+ Hits 953 972 +19
+ Misses 91 80 -11
+ Partials 39 31 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GraemeWatt
force-pushed
the
upgrade-pylint
branch
from
fdb6b5e to
32fe4e7
Compare
* pylintrc and tests/pylintrc generated with Pylint 3.1.0 by running "pylint --generate-rcfile" in a Python 3.11 virtual environment. * Tweaked code and "pylintrc" files so that Pylint checks all pass. * Add Python 3.11 and ROOT 6.30 to matrix in tests.yml. * Skip Pylint step in CI for Python 3.6 and Python 3.7. * ROOT binary built with Python 3.12 not yet supported by Micromamba. * Closes #234.
GraemeWatt
force-pushed
the
upgrade-pylint
branch
from
32fe4e7 to
08b563c
Compare
GraemeWatt
changed the title
Merged
clelange
reviewed
Apr 3, 2024
Collaborator
clelange
left a comment
clelange
left a comment
There was a problem hiding this comment.
Thanks, it's very useful to remove the pin on pylint! I left two comments for your consideration before merging this.
* Just use default Pylint configuration making sure that checks pass. * Tweak code for "consider-using-f-string" and "unspecified-encoding". * Need to disable "no-name-in-module" and "no-member" checks for ROOT.
clelange
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://hepdata-lib--260.org.readthedocs.build/en/260/