Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algorithm: combined sinc for multi-channel resampling
The sinc interpolation inner loop has been restructured. Previously, each channel performed
Nseparate SIMD dot products per output frame (one per nearest polyphase point — 4 for Cubic, 3 for Quadratic, 2 for Linear). The new approach builds a single combined sinc filter per frame by linearly blending the nearest polyphase filters with their interpolation weights, then does one dot product per channel against that combined filter.This trades a one-time per-frame build cost for a cheaper per-channel evaluation. The build step uses SIMD SAXPY (
combined += weight * sinc[k]), accelerated with FMA on AVX/NEON and multiply-add on SSE.The combined path is selected adaptively based on channel count, since for few channels the build overhead outweighs the savings:
Performance (vs master, scalar and NEON, measured on Apple Silicon)
Nearest mode does not use the combined path and shows small regressions of 1–5%, likely from minor overhead introduced by the architectural refactor (sinc storage changed from packed SIMD vectors to plain
Vec<T>).Other changes
Vec<Vec<T>>instead of packed SIMD register types (Vec<__m256>etc.). Load intrinsics work equally well on unalignedT*pointers, so no functional change, but the code is significantly simpler.