Skip to content

feat: add BUDGET_TEAM to For Review tab access#5662

Merged
rajohnson90 merged 1 commit into
mainfrom
OPS-5615/readd-budget-team
May 15, 2026
Merged

feat: add BUDGET_TEAM to For Review tab access#5662
rajohnson90 merged 1 commit into
mainfrom
OPS-5615/readd-budget-team

Conversation

@rajohnson90
Copy link
Copy Markdown
Contributor

@rajohnson90 rajohnson90 commented May 13, 2026

What changed

Added BUDGET_TEAM role to the list of roles that can access the "For Review" tab on the agreements page. Previously only REVIEWER_APPROVER and SUPER_USER had access.

frontend/src/pages/agreements/list/AgreementsTabs.jsx

  • Updated displayReviewTab logic to include USER_ROLES.BUDGET_TEAM check
  • Updated comment to reflect all three authorized roles

frontend/src/pages/agreements/list/AgreementTabs.test.jsx

  • Added test case "does render for budget team" verifying BUDGET_TEAM users see the For Review tab
  • Test follows existing pattern for SUPER_USER and REVIEWER_APPROVER tests

Issue

#5615

How to test

  1. Unit tests:

    cd frontend
    npm test -- AgreementTabs.test.jsx --run
  2. Manual verification:

    • Log in as a user with BUDGET_TEAM role
    • Navigate to /agreements
    • Verify the "For Review" tab appears alongside "All Agreements" and "My Agreements"
    • Log in as a user without BUDGET_TEAM/REVIEWER_APPROVER/SUPER_USER roles
    • Verify the "For Review" tab does not appear

A11y impact

  • No accessibility-impacting changes in this PR
  • Accessibility changes included and validated against WCAG 2.1 AA intent
  • Any temporary suppression includes A11Y-SUPPRESSION metadata (owner, expires, rationale)

Screenshots

Screenshot 2026-05-13 at 9 49 15 AM

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

#5615

@rajohnson90 rajohnson90 merged commit 7277653 into main May 15, 2026
62 checks passed
@rajohnson90 rajohnson90 deleted the OPS-5615/readd-budget-team branch May 15, 2026 15:49
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.391.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants