feat: add BUDGET_TEAM to For Review tab access#5662
Merged
Conversation
josbell
approved these changes
May 13, 2026
josbell
approved these changes
May 13, 2026
Santi-3rd
approved these changes
May 14, 2026
Contributor
|
🎉 This PR is included in version 1.391.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added BUDGET_TEAM role to the list of roles that can access the "For Review" tab on the agreements page. Previously only REVIEWER_APPROVER and SUPER_USER had access.
frontend/src/pages/agreements/list/AgreementsTabs.jsx
displayReviewTablogic to includeUSER_ROLES.BUDGET_TEAMcheckfrontend/src/pages/agreements/list/AgreementTabs.test.jsx
"does render for budget team"verifying BUDGET_TEAM users see the For Review tabIssue
#5615
How to test
Unit tests:
Manual verification:
/agreementsA11y impact
A11Y-SUPPRESSIONmetadata (owner, expires, rationale)Screenshots
Definition of Done Checklist
Links
#5615