Skip to content

[Issue #642] Moving dev dependencies to pnpm catalog#705

Merged
jcrichlake merged 8 commits intomainfrom
642-dev-dependencies
Apr 13, 2026
Merged

[Issue #642] Moving dev dependencies to pnpm catalog#705
jcrichlake merged 8 commits intomainfrom
642-dev-dependencies

Conversation

@jcrichlake
Copy link
Copy Markdown
Collaborator

@jcrichlake jcrichlake commented Apr 13, 2026 •
edited
Loading

Summary

Changes proposed

What was added, updated, or removed in this PR.

This PR moves shared dev dependencies from standalone values to the pnpm catalog feature to reduce effort for future updates

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Ran the formatting for impacted modules as well as ran pnpm test:coverage for lib/ts-sdk and lib/cli. pnpm test was ran on the website module and lib/changelog-emitter.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

ts-sdk tests

image

cli tests

image

website tests

image

changelog emitter test
image

@github-actions github-actions Bot added cli Issue or PR related to the @common-grants/cli library website Issues related to the website core Issues related to @common-grants/core library dependencies Pull requests that update a dependency file python Issue or PR related to Python tooling sdk Issue or PR related to our SDKs typescript Issue or PR related to TypeScript tooling py-sdk Related to Python SDK ts-sdk Related to TypeScript SDK labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026 •
edited
Loading

🚀 Website Preview Deployed!

Preview your changes at: https://cg-pr-705.billy-daly.workers.dev

This preview will be automatically deleted when the PR is closed.

@jcrichlake jcrichlake changed the title Moving dev dependencies to pnpm catalog [Issue #642] Moving dev dependencies to pnpm catalog Apr 13, 2026
widal001
widal001 reviewed Apr 13, 2026
View reviewed changes
Comment thread pnpm-workspace.yaml Outdated

catalogs:
website:
prettier: 3.4.2
Copy link
Copy Markdown
Collaborator

@widal001 widal001 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a development dependency that prevented the website from sharing 3.8.1 with the other sections of the workspace?

Copy link
Copy Markdown
Collaborator Author

@jcrichlake jcrichlake Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I'll update this! Thanks for catching that and for getting on this review so quickly!!

@jcrichlake jcrichlake marked this pull request as ready for review April 13, 2026 19:10
@widal001
Copy link
Copy Markdown
Collaborator

widal001 commented Apr 13, 2026 •
edited
Loading

@jcrichlake can we split the lib/python-sdk/ updates into their own PR? Those will require a changeset and a new patch release and I think they can/should be made relatively independently from the dev dependencies to the TypeScript libraries.

SnowboardTechie
SnowboardTechie approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs and tests nicely locally. I dig the consolidation of dependencies 👏🏻

widal001
widal001 approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating these dev dependencies!

@jcrichlake jcrichlake merged commit 55f7136 into main Apr 13, 2026
12 checks passed
@jcrichlake jcrichlake deleted the 642-dev-dependencies branch April 13, 2026 20:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

🗑️ Preview Cleaned Up

The preview for this PR has been automatically deleted.

@SnowboardTechie SnowboardTechie mentioned this pull request Apr 23, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SnowboardTechie SnowboardTechie SnowboardTechie approved these changes

@widal001 widal001 widal001 approved these changes

Assignees

No one assigned

Labels

cli Issue or PR related to the @common-grants/cli library core Issues related to @common-grants/core library dependencies Pull requests that update a dependency file py-sdk Related to Python SDK python Issue or PR related to Python tooling sdk Issue or PR related to our SDKs ts-sdk Related to TypeScript SDK typescript Issue or PR related to TypeScript tooling website Issues related to the website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Deps] Upgrade shared dev dependencies

3 participants

@jcrichlake @widal001 @SnowboardTechie