fix: pass extra_headers to llm_complete in config test runner#307
Merged
fix: pass extra_headers to llm_complete in config test runner#307
Conversation
The _test_llm method in ConfigTestRunner was not forwarding extra_headers to llm_complete(), causing custom User-Agent and other headers to be ignored during model connection tests. This ensures that user-configured extra_headers in model settings are properly propagated to the LLM API call during connection testing.
Collaborator
|
thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users configure custom
extra_headers(e.g., customUser-Agent) in the model settings page, the connection test still sends the default SDK headers (e.g.,user-agent: AsyncOpenAI/Python 2.31.0) instead of the user-configured values.Root Cause
deeptutor/services/config/test_runner.py— the_test_llmmethod builds anLLMConfigwithextra_headerscorrectly, but does not pass it tollm_complete().Fix
One-line change: add
extra_headers=llm_config.extra_headersto thellm_complete()call.+ extra_headers=llm_config.extra_headers,Impact
{}is falsy and skipped