Conversation
…ions (HKUDS#351) Extract `ComposerInput` component to isolate frequent keystroke renders. Refactor `ChatComposer` to use `hasContent` flag instead of full `input` state. Apply `React.memo` to heavy config panels (Quiz, Math, Research, Visualize). Stabilize parent callbacks in `ChatPage` using `useCallback`. Fix residual syntax errors and missing `canSend` definition in composer. Address HKUDS#351 by implementing deep state colocation.
Collaborator
|
Thanks! that means a lot to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ions (#351)
Extract
ComposerInputcomponent to isolate frequent keystroke renders. RefactorChatComposerto usehasContentflag instead of fullinputstate.Apply
React.memoto heavy config panels (Quiz, Math, Research, Visualize).Stabilize parent callbacks in
ChatPageusinguseCallback. Fix residual syntax errors and missingcanSenddefinition in composer. Address #351 by implementing deep state colocation.Description
This PR addresses the performance regression reported in Issue #351, where the TutorBot chatbox exhibited significant input lag during conversations with 50+ messages. The root cause was "Big State" anti-pattern: every keystroke triggered a re-render of the entire ChatComposer and its heavy sub-components (Quiz/Math/Research panels), as well as unnecessary reconciliation checks for the message list.
Key Changes
Related Issues
Verification Results
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Add any other context or screenshots about the pull request here.