Skip to content

优化 I18n#2948

Merged
Glavo merged 5 commits intoHMCL-dev:mainfrom
Glavo:i18n
Mar 23, 2024
Merged

优化 I18n#2948
Glavo merged 5 commits intoHMCL-dev:mainfrom
Glavo:i18n

Conversation

@Glavo
Copy link
Copy Markdown
Member

@Glavo Glavo commented Mar 23, 2024

  • 修复 org.jackhuang.hmcl.Launcher#register 过早调用 i18n 导致 mods.broken_dependency.titlemods.broken_dependency.desc 未使用配置文件所指定的语言的问题;
  • 惰性加载 resource bundle,避免在启动时加载所有语言的 resource bundle。

@burningtnt
Copy link
Copy Markdown
Member

RemoteMod 那边不能这样改,直接将 register() 后移至 Config 文件加载完成后即可。你这样会让显示上去的文本丢失 I18N

@Glavo
Copy link
Copy Markdown
Member Author

Glavo commented Mar 23, 2024

RemoteMod 那边不能这样改,直接将 register() 后移至 Config 文件加载完成后即可。你这样会让显示上去的文本丢失 I18N

文本显示的逻辑在 DownloadPage 里,这里本来就不该往 HMCLCore 那边放一个本地化后的玩意。

@Glavo Glavo merged commit 94ccee0 into HMCL-dev:main Mar 23, 2024
@Glavo Glavo deleted the i18n branch March 23, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants