导出整合包时将启动器配置集中存放在 .hmcl 文件夹中#3930
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the export functionality to centralize the launcher configuration files inside a dedicated ".hmcl" folder.
- Updated paths for configuration JSON, background, and font files to use the ".hmcl" subdirectory.
- Modified file resolution logic to use fallback paths via Metadata constants.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| HMCL/src/main/java/org/jackhuang/hmcl/ui/export/ExportWizardProvider.java | Updates file export paths and refactors folder resolution for configuration, background, and font files. |
| HMCL/src/main/java/org/jackhuang/hmcl/setting/FontManager.java | Introduces a FONT_EXTENSIONS constant and updates font loading logic accordingly. |
| */ | ||
| public final class FontManager { | ||
|
|
||
| public static String[] FONT_EXTENSIONS = { |
There was a problem hiding this comment.
Declare FONT_EXTENSIONS as final since it represents a constant collection.
Suggested change
| public static String[] FONT_EXTENSIONS = { | |
| public static final String[] FONT_EXTENSIONS = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.