Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the game download page by adding an "All" filter option and improving the version filtering logic. The changes enhance user experience by providing better filtering options and fixing conditional UI layout for version type selection.
- Added "All" filter option to version type dropdown with proper internationalization
- Refactored version filtering logic to properly handle different version types and game-specific filtering
- Fixed UI layout to conditionally show version type dropdown only when the version list supports it
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| I18N_zh_CN.properties | Added Chinese (Simplified) translation for "All" filter option |
| I18N_zh.properties | Added Chinese (Traditional) translation for "All" filter option |
| I18N.properties | Added English translation for "All" filter option |
| VersionsPage.java | Refactored version filtering logic, added ALL filter type, and improved UI layout |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/download/VersionsPage.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/download/VersionsPage.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.