Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Pack200 support from HMCL as the application no longer supports Java 8, making Pack200 compatibility unnecessary since newer Java versions have deprecated or removed Pack200 functionality.
- Completely removes the Pack200Utils utility class
- Updates RemoteVersion to remove Pack200-related download logic and types
- Removes Pack200 decompression handling from HMCLDownloadTask
- Removes Pack200-related classpath entry from build configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/util/Pack200Utils.java | Complete removal of Pack200 utility class |
| HMCL/src/main/java/org/jackhuang/hmcl/upgrade/RemoteVersion.java | Removes Pack200 download option and PACK_XZ type enum |
| HMCL/src/main/java/org/jackhuang/hmcl/upgrade/HMCLDownloadTask.java | Removes Pack200 decompression logic and XZ dependencies |
| HMCL/build.gradle.kts | Removes pack200.jar from classpath configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Oct 13, 2025
Glavo
added a commit
that referenced
this pull request
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目前 HMCL 不再兼容 Java 8,用户所用的 Java 支持 Pack200 的可能性大大降低,继续保留对 Pack200 的支持缺乏意义,所以让我们彻底移除这部分代码。