修复 Windows 平台 GPU 信息可能显示为"[B@xxx" 的问题#4288
Merged
Glavo merged 3 commits intoHMCL-dev:mainfrom Aug 19, 2025
Merged
Conversation
Glavo
reviewed
Aug 19, 2025
| } else if (object instanceof String[]) { | ||
| return String.join(" ", (String[]) object); | ||
| } else if (object instanceof byte[]) { | ||
| return new String((byte[])object); |
Member
There was a problem hiding this comment.
我看你给的截图，里面的字符串数据应该是 UTF-16LE 编码的，你这样实现会导致字符串里存在大量 \0。
而且，请不要在任何地方使用 new String(byte[]) 这个方法，应当总是明确指定字符串的编码。
Glavo
approved these changes
Aug 19, 2025
Glavo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4286 修复Windows启动时注册表项目类型为
REG_BINARY时输出的GPU信息不正常