Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the encoding behavior for invalid surrogate pairs in URIs from a question mark (?) to the Unicode replacement character U+FFF0.
- Updates invalid surrogate pair handling to use U+FFF0 instead of encoding as
%3F(question mark)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+189
to
+190
| // Invalid surrogate pair, encode as U+FFF0 | ||
| encodeCodePoint(builder, 0xfff0); |
There was a problem hiding this comment.
Using U+FFF0 (0xfff0) as a replacement character is non-standard. The Unicode standard defines U+FFFD as the official replacement character for invalid or unrepresentable characters. Consider using 0xfffd instead.
Suggested change
| // Invalid surrogate pair, encode as U+FFF0 | |
| encodeCodePoint(builder, 0xfff0); | |
| // Invalid surrogate pair, encode as U+FFFD | |
| encodeCodePoint(builder, 0xfffd); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
相比
?(%3F)，U+FFFD (replacement character) 更能明确表示这是一个错误字符。