Fix MultiMC modpack update not applying configuration overrides#4382
Merged
Glavo merged 3 commits intoHMCL-dev:mainfrom Sep 7, 2025
Merged
Fix MultiMC modpack update not applying configuration overrides#4382Glavo merged 3 commits intoHMCL-dev:mainfrom
Glavo merged 3 commits intoHMCL-dev:mainfrom
Conversation
burningtnt
suggested changes
Sep 4, 2025
Member
burningtnt
left a comment
burningtnt
left a comment
There was a problem hiding this comment.
createMultiMCPostInstallTask 会覆盖包括内存设置、全屏模式、显示控制台在内的过多设置。在这里，我希望仅更新启动命令（包括包装命令和启动前执行的命令）和JVM 虚拟机参数。
Member
|
你理解错我的意思了。在首次安装整合包时仍应当执行完整的 VersionSetting 设置流程，而在升级整合包时，应当仅调用 |
Contributor
Author
目前的代码就是按照要求的流程执行的，因为 |
burningtnt
approved these changes
Sep 5, 2025
Contributor
Author
|
可能是因为我直接把 |
Contributor
Author
|
ping @Glavo 或许可以合并？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4381
可能需要更好的实现方法