修复 popup 第一次无法计算高度的问题 & 应用此方法到世界管理界面#4412
Merged
Glavo merged 3 commits intoHMCL-dev:mainfrom Sep 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes the issue where popup menus cannot calculate height properly on first display and applies this solution to the world management interface. The PR moves popup position calculation logic to a shared utility method and enhances it to handle first-time popup displays.
- Moved popup position determination logic from GameListItemSkin to FXUtils as a shared utility
- Enhanced the method to handle first-time popup height calculation by forcing layout measurement
- Applied the improved popup positioning to WorldListItemSkin
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FXUtils.java | Added determineOptimalPopupPosition method with enhanced height calculation for first-time popup display |
| GameListItemSkin.java | Removed duplicate popup positioning logic and updated to use the new shared utility method |
| WorldListItemSkin.java | Applied the improved popup positioning logic to world management interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Glavo
reviewed
Sep 11, 2025
Glavo
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4287