[release/3.6] 修复多次启动游戏时内存泄露的问题#4423
Merged
Glavo merged 1 commit intoHMCL-dev:releasefrom Sep 10, 2025
Merged
Conversation
Co-authored-by: Glavo <zjx001202@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak issue that occurs when starting games multiple times by implementing weak references for process management.
- Changes the process storage mechanism from strong references to weak references to allow garbage collection
- Adds cleanup logic to remove dead weak references from the process queue
- Updates process management methods to work with the new weak reference structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| private void launch0() { | ||
| // https://github.com/HMCL-dev/HMCL/pull/4121 |
There was a problem hiding this comment.
[nitpick] The comment should be more descriptive about what this code does. Consider changing it to something like '// Clean up dead weak references to prevent memory leaks' to better explain the purpose of this cleanup operation.
Suggested change
| // https://github.com/HMCL-dev/HMCL/pull/4121 | |
| // https://github.com/HMCL-dev/HMCL/pull/4121 | |
| // Clean up dead weak references to prevent memory leaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4121