Close #2987: 从 java.io.File 迁移至 NIO#4502
Merged
Glavo merged 7 commits intoHMCL-dev:mainfrom Sep 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from using java.io.File to the NIO java.nio.file.Path API, addressing issue #2987. The migration improves code modernization by adopting the more flexible and feature-rich NIO.2 file system API.
- Replaces
FileAPI calls with equivalentPathoperations throughout the codebase - Removes deprecated
File-based constructors and utility methods - Updates method signatures to accept
Pathinstead ofFileparameters
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Architecture.java | Updates file existence check to use Files.exists() with Path.of() |
| Unzipper.java | Removes deprecated File-based constructor |
| FileUtils.java | Removes toFile() utility method |
| JsonUtils.java | Removes File type adapter registration |
| FileTypeAdapter.java | Deletes entire file as it's no longer needed |
| Launcher.java | Changes makeLaunchScript method signature to accept Path |
| DefaultLauncher.java | Updates script creation logic to use Path operations |
| DefaultGameRepository.java | Updates event firing to pass Path instead of File |
| GameJsonParseFailedEvent.java | Changes field and constructor to use Path |
| MojangJavaDownloadTask.java | Replaces file operations with NIO equivalents |
| Multiple UI files | Updates method calls to use Path parameters |
| ModpackHelper.java | Converts file reading methods to use Path |
| LauncherHelper.java | Updates script file handling to use Path |
| HMCLGameLauncher.java | Updates method signature to use Path |
| Config.java | Removes File type adapter registration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.