Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the message display for unrecognized mods by adding specific localization for unknown mods. The main purpose is to provide better user feedback when HMCL encounters mods that cannot be properly identified or categorized.
Key changes:
- Added localization strings for "Unknown Mod" in English, Simplified Chinese, and Traditional Chinese
- Modified mod display logic to show "Unknown Mod" warning for mods with UNKNOWN loader type
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| I18N.properties | Added English localization for unknown mod message |
| I18N_zh_CN.properties | Added Simplified Chinese localization for unknown mod message |
| I18N_zh.properties | Added Traditional Chinese localization for unknown mod message |
| ModListPageSkin.java | Updated mod display logic to handle unknown mod type with specific warning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.