Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes case-sensitive mod sorting by implementing case-insensitive comparison. The change addresses issue #4663 where mod modules should be sorted ignoring case sensitivity.
Key changes:
- Updated LocalModFile comparison to use case-insensitive sorting
- Simplified ModInfoObject by removing redundant comparison logic
- Streamlined mod loading process by moving object creation earlier in the pipeline
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LocalModFile.java | Changed compareTo method to use compareToIgnoreCase for case-insensitive sorting |
| ModListPageSkin.java | Removed redundant Comparable implementation and compareTo method from ModInfoObject |
| ModListPage.java | Moved ModInfoObject creation to earlier stage in loadMods method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| static final class ModInfoObject extends RecursiveTreeObject<ModInfoObject> implements Comparable<ModInfoObject> { | ||
| static final class ModInfoObject { |
There was a problem hiding this comment.
The ModInfoObject class should extend RecursiveTreeObject if it's used in a tree structure. Removing this inheritance may break tree functionality unless you've verified that tree operations are no longer needed.
Suggested change
| static final class ModInfoObject { | |
| static final class ModInfoObject extends RecursiveTreeObject<ModInfoObject> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.