Skip to content

[Bugfix] #4863: macOS 上错误的 Modrinth 整合包默认文件名称#4864

Merged
Glavo merged 7 commits intoHMCL-dev:mainfrom
Calboot:fix-4863
Nov 30, 2025
Merged

[Bugfix] #4863: macOS 上错误的 Modrinth 整合包默认文件名称#4864
Glavo merged 7 commits intoHMCL-dev:mainfrom
Calboot:fix-4863

Conversation

@Calboot
Copy link
Copy Markdown
Contributor

@Calboot Calboot commented Nov 25, 2025

Fixes #4863

@Calboot Calboot closed this Nov 25, 2025
@Calboot Calboot reopened this Nov 25, 2025
@Calboot Calboot marked this pull request as ready for review November 25, 2025 11:09
@Calboot Calboot changed the title Fix #4863: 错误的 Modrinth 整合包默认文件名称 Fix #4863: macOS 上错误的 Modrinth 整合包默认文件名称 Nov 25, 2025
@Calboot Calboot changed the title Fix #4863: macOS 上错误的 Modrinth 整合包默认文件名称 [Bugfix] #4863: macOS 上错误的 Modrinth 整合包默认文件名称 Nov 25, 2025
@Calboot
Copy link
Copy Markdown
Contributor Author

Calboot commented Nov 25, 2025

在 Windows 和 mac 上均测试通过

@Glavo
Copy link
Copy Markdown
Member

Glavo commented Nov 26, 2025

在 KUbuntu 24.04 上进行了测试,使用本 PR 会导出没有后缀名的文件。

@Calboot
Copy link
Copy Markdown
Contributor Author

Calboot commented Nov 26, 2025

可能是不同操作系统实现逻辑不同?
我再改改

@Calboot
Copy link
Copy Markdown
Contributor Author

Calboot commented Nov 26, 2025

感觉是 macOS 应对不能识别的文件扩展名的逻辑有问题,那就加个特判就好了,这样只影响 mac

@Calboot
Copy link
Copy Markdown
Contributor Author

Calboot commented Nov 26, 2025

在 Windows ARM 和 macOS 26 上测试通过

@Glavo
Copy link
Copy Markdown
Member

Glavo commented Nov 30, 2025

把无关修改还原一下吧。这些地方用 == 是合理的,不需要使用 equals

@Calboot
Copy link
Copy Markdown
Contributor Author

Calboot commented Nov 30, 2025

ok了

@Glavo Glavo merged commit 6558b3b into HMCL-dev:main Nov 30, 2025
2 checks passed
@Calboot Calboot deleted the fix-4863 branch November 30, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] macOS 上导出 Modrinth 整合包时默认文件名有两个后缀名

2 participants