[release/3.8] 修复 ManagedProcess#getLines 完成后不会解除锁定的问题#4982
Merged
Glavo merged 1 commit intoHMCL-dev:release/3.8from Dec 18, 2025
Merged
[release/3.8] 修复 ManagedProcess#getLines 完成后不会解除锁定的问题#4982Glavo merged 1 commit intoHMCL-dev:release/3.8from
Glavo merged 1 commit intoHMCL-dev:release/3.8from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical concurrency bug in the ManagedProcess#getLines method where the lock would not be released if an exception occurred during execution, potentially leading to deadlocks.
- Wraps the method body in a try-finally block to ensure the lock is always released
- Aligns the lock management pattern with other methods in the class (
addLine,addRelatedThread,destroyRelatedThreads)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4913