Skip to content

更新 ToolbarListPageSkin 以使用 JFXListView 展示节点#5221

Merged
Glavo merged 3 commits intoHMCL-dev:mainfrom
Glavo:skin
Jan 13, 2026
Merged

更新 ToolbarListPageSkin 以使用 JFXListView 展示节点#5221
Glavo merged 3 commits intoHMCL-dev:mainfrom
Glavo:skin

Conversation

@Glavo
Copy link
Copy Markdown
Member

@Glavo Glavo commented Jan 13, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the ToolbarListPageSkin class to use JFXListView instead of ScrollPane + VBox for displaying list items, completing a planned migration from the temporary ToolbarListPageSkin2 class.

Changes:

  • Updated ToolbarListPageSkin to use JFXListView with a customizable cell factory pattern
  • Removed the temporary ToolbarListPageSkin2 class (marked with TODO for gradual replacement)
  • Updated all page classes to use the new generic signature ToolbarListPageSkin<E, P>

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
ToolbarListPageSkin.java Refactored to use JFXListView instead of ScrollPane+VBox, added createListCell hook method for customization
ToolbarListPageSkin2.java Deleted temporary class that was being gradually replaced
GameListPage.java Migrated from ToolbarListPageSkin2 to ToolbarListPageSkin, overrides createListCell for custom cell rendering
WorldListPage.java Updated skin class signature to include generic type parameters, changed return type to be less specific
WorldBackupsPage.java Updated skin class signature to include BackupInfo generic type parameter
SchematicsPage.java Updated skin class signature to include Item generic type parameter
InstallerListPage.java Updated skin class signature to include InstallerItem generic type parameter
JavaRestorePage.java Updated skin class signature to include DisabledJavaItem generic type parameter
JavaManagementPage.java Updated skin class signature to include JavaItem generic type parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit ea407be into HMCL-dev:main Jan 13, 2026
8 checks passed
@Glavo Glavo deleted the skin branch January 13, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants