更新 ToolbarListPageSkin 以使用 JFXListView 展示节点#5221
Merged
Glavo merged 3 commits intoHMCL-dev:mainfrom Jan 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the ToolbarListPageSkin class to use JFXListView instead of ScrollPane + VBox for displaying list items, completing a planned migration from the temporary ToolbarListPageSkin2 class.
Changes:
- Updated
ToolbarListPageSkinto useJFXListViewwith a customizable cell factory pattern - Removed the temporary
ToolbarListPageSkin2class (marked with TODO for gradual replacement) - Updated all page classes to use the new generic signature
ToolbarListPageSkin<E, P>
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ToolbarListPageSkin.java | Refactored to use JFXListView instead of ScrollPane+VBox, added createListCell hook method for customization |
| ToolbarListPageSkin2.java | Deleted temporary class that was being gradually replaced |
| GameListPage.java | Migrated from ToolbarListPageSkin2 to ToolbarListPageSkin, overrides createListCell for custom cell rendering |
| WorldListPage.java | Updated skin class signature to include generic type parameters, changed return type to be less specific |
| WorldBackupsPage.java | Updated skin class signature to include BackupInfo generic type parameter |
| SchematicsPage.java | Updated skin class signature to include Item generic type parameter |
| InstallerListPage.java | Updated skin class signature to include InstallerItem generic type parameter |
| JavaRestorePage.java | Updated skin class signature to include DisabledJavaItem generic type parameter |
| JavaManagementPage.java | Updated skin class signature to include JavaItem generic type parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/InstallerListPage.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.