Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for right-clicking sidebar items to show a popup menu for switching game instances. The implementation introduces a reusable utility method and refactors existing code to eliminate duplication.
Changes:
- Added
FXUtils.onSecondaryButtonClicked()utility method for handling right-click events - Extracted popup menu logic into
GameListPopupMenu.show()static method - Applied right-click menu support to multiple sidebar items (account list, game list, version management)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| FXUtils.java | Added new onSecondaryButtonClicked() utility method for handling secondary mouse button clicks |
| GameListPopupMenu.java | Added static show() method to create and display game list popup menu |
| RootPage.java | Refactored to use new utility method, added right-click support for game-related sidebar items, removed unused import |
| MainPage.java | Refactored to use new static show() method, removed duplicate onMenu() method and unused import |
| TerracottaPage.java | Added right-click support for instance switching in terracotta page |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.