修复清理游戏资源 / 库操作在 FXThread 运行的问题

[CiiLu]

改为和删除实例一样的逻辑

[burningtnt]

你在搞什么鬼

[Copilot]

Pull request overview

该 PR 旨在修复“清理游戏资源/库文件时在 FXThread 执行导致卡 UI”的问题，将清理操作改为与删除实例类似的异步执行逻辑。

Changes:

• 将清理 libraries 目录的删除操作迁移到 Schedulers.io() 异步执行，并在 Schedulers.javafx() 回调中处理异常提示
• 将清理 assets 与实例 resources 目录的删除操作迁移到 Schedulers.io() 异步执行，并在 Schedulers.javafx() 回调中处理异常提示
• 增加相关 Task/调度/异常展示所需的 import

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

FileUtils.deleteDirectoryQuietly swallows IOExceptions and only returns a boolean, so this task will usually complete with exception == null even when deletion fails (permissions/locked files). If you want the error dialog to trigger, use deleteDirectory (let IOException propagate) or check the boolean result and fail the task explicitly when it returns false.

[Copilot]

The error dialog concatenates i18n("message.failed") and the stack trace without a separator, which makes the message hard to read. Add a newline (as done elsewhere, e.g. "..." + "\n" + StringUtils.getStackTrace(...)).

[Copilot]

Inside the IO task you read version.get() (a JavaFX property) and derived values from it. Capture the version name (or the resources path) on the FX thread before scheduling to avoid cross-thread access to JavaFX properties and to ensure a consistent target if the selection changes while the task is running.

Suggested change

	Task.runAsync(Schedulers.io(), () -> {
	HMCLGameRepository baseDirectory = getProfile().getRepository();
	FileUtils.deleteDirectoryQuietly(baseDirectory.getBaseDirectory().resolve("assets"));
	if (version.get() != null) {
	FileUtils.deleteDirectoryQuietly(baseDirectory.getRunDirectory(version.get().getVersion()).resolve("resources"));
	HMCLGameRepository baseDirectory = getProfile().getRepository();
	String versionId = (version.get() != null) ? version.get().getVersion() : null;
	Task.runAsync(Schedulers.io(), () -> {
	FileUtils.deleteDirectoryQuietly(baseDirectory.getBaseDirectory().resolve("assets"));
	if (versionId != null) {
	FileUtils.deleteDirectoryQuietly(baseDirectory.getRunDirectory(versionId).resolve("resources"));

[Copilot]

Same as above: deleteDirectoryQuietly will not throw, so exception will remain null on common deletion failures. If you need to report failure to the user, use a throwing delete or convert the boolean return value into a task failure.

[Copilot]

This dialog message also misses a separator between the localized failure text and the stack trace; add a newline for readability.

[Copilot]

The background task calls getProfile()/version.get() (JavaFX properties) from the IO executor. JavaFX properties are not thread-safe; snapshot the needed values (e.g., repository base path / selected version string) on the FX thread before starting the task, and only use those captured values inside runAsync.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

FileUtils.deleteDirectoryQuietly(...) swallows IOException and returns false, so this Task.runAsync(...) closure will usually complete successfully even when deletion fails. As a result, whenComplete(..., exception -> ...) won’t show an error dialog on common failures. If you want to report failures, use deleteDirectory(...) (let the exception propagate) or check the boolean result and throw/show an error accordingly.

[Copilot]

Same as above: deleteDirectoryQuietly(...) catches IOException, so this task will not surface typical deletion failures via exception. Consider using deleteDirectory(...) or handling the boolean return to ensure the UI can inform users when cleanup fails.