Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an installation issue with LegacyFabric for older Minecraft versions (like 1.5.2) that use LaunchWrapper. The previous implementation incorrectly applied a compatibility check designed for modern Fabric, which prevented LegacyFabric installation on LaunchWrapper-based versions even though LegacyFabric is specifically designed to support these old versions.
Changes:
- Removed incompatible main class check from LegacyFabricInstallTask
- Cleaned up unused imports (UnsupportedInstallationException and related constants)
- Reorganized java.util imports to use explicit imports instead of wildcard
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个版本 LegacyFabric 也是使用的 LaunchWrapper，现在的实现会在安装的时候直接提示不兼容
