Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a local modpack installation error by refactoring how the hasSource flag is computed and stored in the ModpackInstallWizardProvider class.
Changes:
- Added
hasSourceas an instance field to cache whether a modpack source is available - Moved the computation of
hasSourcefrom thecreatePage()method to thestart()method for better consistency and to fix an inconsistency in the original code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Feb 23, 2026
Closed
Closed
Glavo
pushed a commit
to Glavo/HMCL
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.