Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors HMCL’s JFoenix spinner styling and implementation, simplifying CSS rules and streamlining the spinner skin while adjusting default sizing/appearance.
Changes:
- Simplified
root.cssspinner-related selectors and adjusted “small” spinner radius. - Updated
JFXSpinnerSkinto remove determinate percentage text rendering and to rely onTreeShowingPropertyfor animation start/stop. - Updated
JFXSpinnerdefaults (radius) and replaced the styleable starting-angle property with a randomized starting angle.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/css/root.css | Removes multiple spinner size selectors and tweaks small spinner sizing rules. |
| HMCL/src/main/java/com/jfoenix/skins/JFXSpinnerSkin.java | Simplifies skin nodes (removes percentage text), standardizes default stroke width, and caches starting angle. |
| HMCL/src/main/java/com/jfoenix/controls/JFXSpinner.java | Adjusts default radius and changes starting angle behavior to be randomized. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -fx-stroke-width: 5.0; | ||
| -jfx-radius: 9; | ||
| } | ||
|
|
Comment on lines
102
to
104
| } | ||
|
|
||
| private static final class StyleableProperties { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
调整 JFXSpinner 的默认大小以及笔触宽度以匹配 MD3 样式。
考虑到 MD3 也不会在进度指示器内部显示进度，本 PR 还移除了 HMCL 中没有用到的 JFXSpinner 内部文本控件。