Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 将版本设置页中的“内存使用/分配”进度条抽象为可复用的 UI 控件,并同步调整对应的 CSS 样式,以便统一内存状态栏的显示与更新逻辑。
Changes:
- 新增
MemoryStatusBar控件:封装物理内存状态轮询与绘制逻辑 VersionSettingsPage使用MemoryStatusBar替换原先手写的StackPane进度条实现- 更新
root.css:用.memory-status-bar及其子节点样式替代原.memory-used/.memory-allocate/.memory-total的样式定义
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/css/root.css | 为新的 MemoryStatusBar 结构(track + rectangles)提供样式规则,并移除旧进度条样式块 |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java | 接入 MemoryStatusBar,将内存显示与分配绑定迁移到新控件 |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/MemoryStatusBar.java | 新增内存状态栏控件与皮肤实现,包含后台轮询更新逻辑 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.