种子地图、要塞地图、下届要塞地图和末地城地图支持 26.1#5860
Conversation
There was a problem hiding this comment.
Pull request overview
Updates HMCL’s ChunkBase integration so the launcher can open ChunkBase web apps using the correct platform value for the newly added Java 26.1 version (and aligns the supported version lists with ChunkBase’s current dropdowns).
Changes:
- Added
26.1to the supported version lists used to build ChunkBase URLs. - Expanded the per-app supported-version arrays (seed map / stronghold / nether fortress / end city) to match ChunkBase’s current version groupings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static final String[] STRONGHOLD_FINDER_GAME_VERSIONS = { | ||
| "1.20", "1.19.3", "1.19", "1.18", "1.16", "1.13", "1.9", "1.7" | ||
| "26.1", "1.21.9", "1.21.6", "1.21.5", "1.21.4", "1.21.2", "1.21", | ||
| "1.20", "1.19.3", "1.19", "1.18", "1.17", "1.16", "1.15", "1.14", | ||
| "1.13", "1.12", "1.11", "1.10", "1.9", "1.8", "1.7" | ||
| }; |
There was a problem hiding this comment.
STRONGHOLD_FINDER_GAME_VERSIONS now contains the same entries as SEED_MAP_GAME_VERSIONS, so the version list is duplicated and must be updated in multiple places when ChunkBase changes supported versions. Consider extracting a single shared constant (e.g., COMMON_GAME_VERSIONS) and referencing it here to avoid future drift.
| public static final String[] NETHER_FORTRESS_GAME_VERSIONS = { | ||
| "1.18", "1.16", "1.7" | ||
| "26.1", "1.21.9", "1.21.6", "1.21.5", "1.21.4", "1.21.2", "1.21", | ||
| "1.20", "1.19.3", "1.19", "1.18", "1.17", "1.16", "1.15", "1.14", | ||
| "1.13", "1.12", "1.11", "1.10", "1.9", "1.8", "1.7" | ||
| }; |
There was a problem hiding this comment.
NETHER_FORTRESS_GAME_VERSIONS duplicates the same supported-version list used elsewhere in this class. Consider reusing a shared constant to reduce maintenance overhead and avoid inconsistent updates across apps.
| public static final String[] STRONGHOLD_FINDER_GAME_VERSIONS = { | ||
| "1.20", "1.19.3", "1.19", "1.18", "1.16", "1.13", "1.9", "1.7" | ||
| "26.1", "1.21.9", "1.21.6", "1.21.5", "1.21.4", "1.21.2", "1.21", | ||
| "1.20", "1.19.3", "1.19", "1.18", "1.17", "1.16", "1.15", "1.14", |
There was a problem hiding this comment.
These version arrays are declared public static final, but they appear to be referenced only within ChunkBaseApp in the current codebase. If they’re not intended as part of the external API, consider making them private (or exposing an immutable view) to avoid accidental external mutation and reduce API surface.
#5860 Co-authored-by: neveler <55753029+neveler@users.noreply.github.com>
https://www.chunkbase.com/apps/seed-map
https://www.chunkbase.com/apps/stronghold-finder
https://www.chunkbase.com/apps/nether-fortress-finder
https://www.chunkbase.com/apps/endcity-finder