Skip to content

优化原理图管理&世界管理输入校验#5923

Merged
Glavo merged 1 commit intoHMCL-dev:mainfrom
CiiLu:vvvv
Apr 6, 2026
Merged

优化原理图管理&世界管理输入校验#5923
Glavo merged 1 commit intoHMCL-dev:mainfrom
CiiLu:vvvv

Conversation

@CiiLu
Copy link
Copy Markdown
Contributor

@CiiLu CiiLu commented Apr 6, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 通过复用 Controllers.prompt(...) + Validator 体系,统一并加强了“世界复制”和“原理图目录创建”的输入校验逻辑,从而减少重复校验代码并提升交互一致性。

Changes:

  • 将手写的空/非法名称判断迁移为 RequiredValidator + Validator(FileUtils::isNameValid) 的表单校验。
  • Controllers.prompt(...) 替代直接构造 InputDialogPane 的调用方式,统一弹窗入口。

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManageUIUtils.java 世界复制弹窗改用 Controllers.prompt 并通过校验器统一输入校验。
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/SchematicsPage.java 创建目录弹窗改用 Controllers.prompt 并引入统一的输入校验器。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit 20e321f into HMCL-dev:main Apr 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants