Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 通过复用 Controllers.prompt(...) + Validator 体系,统一并加强了“世界复制”和“原理图目录创建”的输入校验逻辑,从而减少重复校验代码并提升交互一致性。
Changes:
- 将手写的空/非法名称判断迁移为
RequiredValidator+Validator(FileUtils::isNameValid)的表单校验。 - 用
Controllers.prompt(...)替代直接构造InputDialogPane的调用方式,统一弹窗入口。
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldManageUIUtils.java | 世界复制弹窗改用 Controllers.prompt 并通过校验器统一输入校验。 |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/SchematicsPage.java | 创建目录弹窗改用 Controllers.prompt 并引入统一的输入校验器。 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.