Merged
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the 'no-horizontal-scrollbar' style class to the log window's list view. However, the feedback points out that the necessary CSS definition for this class is missing, making the change ineffective. Additionally, there is a concern that disabling horizontal scrolling may hinder the readability of long log strings that do not wrap automatically.
| LogWindowImpl() { | ||
| getStyleClass().add("log-window"); | ||
|
|
||
| listView.getStyleClass().add("no-horizontal-scrollbar"); |
There was a problem hiding this comment.
此更改仅添加了样式类 no-horizontal-scrollbar，但 PR 中未包含对应的 CSS 定义，导致该样式类无法生效。此外，禁用横向滚动条会导致无法自动换行的超长字符串（如 Base64 数据）无法完整显示，这可能影响日志的可读性。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.