Minor improvements to code#2
Open
sakluk wants to merge 11 commits into
Open
Conversation
…n by zero. Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Comennted out np.log(PvO2) in pHTempCorrection. Removed lnPvO2 from the exp. Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Signed-off-by: tommiluk <sakari.lukkarinen@metropolia.fi>
Solver modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, the Severinghaus' O2 dissolution curve is changed to numerically better format to handle also PvO2 = 0 values.
Second, unused codes for PvO2_coef and PvO2_err were commented out in calc(), setCalcResults(), and class WorkLoadDetails(). This seems to work fine.
Thirdly, in O2PTsolver > phTempCorrection function was calculate np.log(PvO2). If PvO2 is allowed to have also 0 values, the code needed to be changed to avoid np.log(0). Thus the return value was changed to PvO2 *= np.exp(lnPO2Temp + lnPO2pH) which is mathematically same as the original code.