Cleanups to make cskiplist locking easier to experiment with

[unkadoug]

Eliminate a couple of layers of files and function calls between ui_tree.c and cskiplists, and remove references to the specific kind of lock used for cskiplists. While this was done as a prerequisite to a test of big read locks for cskiplists, the elimination of code clutter alone makes this worth doing.

[pmucci]

Allow me to compliment you folks on this skiplist implementation. It’s really nice, clean and appears to have killer performance. I sure wish the PAPI code looked like this! Philip J. Mucci Minimal Metrics LLC Ph: +1.415.841.3577 | +46(0)72.172.2581 Fax: +1.415.689.3976 www.minimalmetrics.com <http://www.minimalmetrics.com/>

…

On Jan 15, 2017, at 4:57 AM, Doug Moore ***@***.***> wrote: Eliminate a couple of layers of files and function calls between ui_tree.c and cskiplists, and remove references to the specific kind of lock used for cskiplists. While this was done as a prerequisite to a test of big read locks for cskiplists, the elimination of code clutter alone makes this worth doing. You can view, comment on, or merge this pull request online at: #3 <#3> Commit Summary Change comments so that they don't refer to the kind of lock used, Call them locks, not pfq_locks. Consolidate a few read_unlocks to reduce their number. Avoid duplicate cskiplist type declarations by reading a new header. Remove cskiplist_ilmstat_btuwi_pair.[ch], a pointless intermediate layer. Drop needless #include Drop addr_to_range.[ch], which is another useless layer between ui_tree and cskiplist. Remove useless function. Remove needless cast. Restore arithmetic on intptr_t rather than doing in on void*. Edit a comment that mentions lock implementation. remove trailing whitespace. File Changes M src/lib/prof-lean/cskiplist.c <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-0> (96) M src/lib/prof-lean/cskiplist.h <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-1> (24) A src/lib/prof-lean/cskiplist_defs.h <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-2> (83) M src/tool/hpcrun/Makefile.am <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-3> (2) M src/tool/hpcrun/Makefile.in <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-4> (48) D src/tool/hpcrun/unwind/common/addr_to_recipe_map.c <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-5> (121) D src/tool/hpcrun/unwind/common/addr_to_recipe_map.h <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-6> (94) D src/tool/hpcrun/unwind/common/cskiplist_ilmstat_btuwi_pair.c <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-7> (146) D src/tool/hpcrun/unwind/common/cskiplist_ilmstat_btuwi_pair.h <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-8> (75) M src/tool/hpcrun/unwind/common/ui_tree.c <https://github.com/HPCToolkit/hpctoolkit/pull/3/files#diff-9> (121) Patch Links: https://github.com/HPCToolkit/hpctoolkit/pull/3.patch <https://github.com/HPCToolkit/hpctoolkit/pull/3.patch> https://github.com/HPCToolkit/hpctoolkit/pull/3.diff <https://github.com/HPCToolkit/hpctoolkit/pull/3.diff> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMUJEPaRDdonlAbyQHasoyHNcyU5R2qJks5rSZkegaJpZM4Lj0a1>.

[unkadoug]

Merge my changes to shorten the ui_tree->(skip list) path.