This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Merged
Conversation
…ged from .L_<number> to .L_x_<number>, so new code is added to extract name using the new pattern
Member
|
Keren and I had a discussion over zoom about making the code a bit less fragile. Rather than matching anything after .L, he could skip past non-digits and just grab the digits afterwards. There also is no need for two induction variables label_length and digit_pos, which both specify the length of the digit string. After the .L, the string position can be advanced to digit_start, digit_end can be found by skipping all digits, and the length can be computed as the difference. |
Member
Author
|
@jmellorcrummey Thanks for the suggestion. Please check the simplified code. |
jmellorcrummey
approved these changes
Jan 21, 2022
Member
jmellorcrummey
left a comment
jmellorcrummey
left a comment
There was a problem hiding this comment.
The second version looks great. I'll merge it immediately.
Jokeren
added a commit
that referenced
this pull request
Jan 29, 2022
* Fix cuda CFG parsing problem for CUDA >= 11.5: target label names were changed from .L_<number> to .L_x_<number>. Code was adjusted to be less sensitive to the form of the label name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a cuda cfg parsing problem for CUDA >= 11.5: target labels are changed from .L_ to .L_x_, so new code is added to extract name using the new pattern.
Interestingly, using cuda-11.6 collects 13% less samples than cuda-11.4 for quicksilver, but it has nothing to do with postmortem analysis. I confirmed this issue using hpctoolkit's log file.